Rewrite protect_pip_from_modification_on_windows #7558
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #7358 to implement a better logic with less edge cases. The implementation is put in its own module and functions so it can be improved on in the future.
The logic I have in mind is:
sys.argv[0]
) looks like a path. If it does not (and therefore will be resolved by the shell as a command), useshutil.which
to resolve it.python src\pip
case).