-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Bitwise AND to set permissions in utils/unpacking.py #8179
Comments
Hi @sbidoul , @pradyunsg Do we still want to make the above mentioned changes? If yes, I can go ahead and make a PR for the same. |
@deveshks yes, please go ahead. |
Thanks, I have filed the PR. Please have a look |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Originally triaged in #8164
We are using
0o777 - current_umask()
to set file permissions, but we should be using a Bitwise AND (0o777 & ~current_umask()
)pip/src/pip/_internal/utils/unpacking.py
Line 148 in 43426ee
pip/src/pip/_internal/utils/unpacking.py
Line 232 in 43426ee
We would also want to move the two
os.chmod
calls into a helper function.The text was updated successfully, but these errors were encountered: