Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mechanism to set permissions for files with execute permissions while extracting sdists. #8375

Merged
merged 3 commits into from
Jun 3, 2020
Merged

Update mechanism to set permissions for files with execute permissions while extracting sdists. #8375

merged 3 commits into from
Jun 3, 2020

Conversation

deveshks
Copy link
Contributor

@deveshks deveshks commented Jun 2, 2020

Fixes #8179

@deveshks deveshks force-pushed the use-bitwise-and branch 2 times, most recently from 46cefb9 to 736f1b2 Compare June 2, 2020 08:39
sbidoul
sbidoul requested changes Jun 2, 2020
View reviewed changes
src/pip/_internal/utils/unpacking.py Outdated Show resolved Hide resolved
news/8179.bugfix Outdated Show resolved Hide resolved
@deveshks deveshks requested a review from sbidoul June 2, 2020 08:55
@deveshks deveshks requested a review from uranusjr June 2, 2020 10:47
@deveshks
Copy link
Contributor Author

deveshks commented Jun 3, 2020

I see that the tests are now passing, and the review comments have been addressed. This PR is ready for further review and approval/merge.

sbidoul
sbidoul approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sbidoul sbidoul merged commit ebd331f into pypa:master Jun 3, 2020
@deveshks deveshks deleted the use-bitwise-and branch June 3, 2020 20:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@uranusjr uranusjr uranusjr approved these changes

@sbidoul sbidoul sbidoul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Bitwise AND to set permissions in utils/unpacking.py
3 participants
@deveshks @uranusjr @sbidoul