Require setup.cfg-only projects to be used with pyproject.toml #10031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FFY00
force-pushed
the
no-setup-cfg
branch
2 times, most recently
from
3ee6875
to
df3d2d4
Compare
pfmoore
approved these changes
May 29, 2021
pradyunsg
requested changes
May 30, 2021
news/10031.bugfix.rst
Outdated
| @@ -0,0 +1 @@ | |||
| Remove support for ``setup.cfg``-only projects. See the discussion in https://github.com/pypa/pip/pull/9945. | |||
There was a problem hiding this comment.
This isn't a good changelog entry IMO. Suggested rephrasing:
Require setup.cfg-only projects to be built via PEP 517, by requiring an explicit dependency on setuptools declared in pyproject.toml.
There was a problem hiding this comment.
Is this a bugfix or a removal ? I don't think this was announced but...
Also does this need to go in yet another 21.1 bugfix release, before people start relying on it ?
There was a problem hiding this comment.
This isn't a good changelog entry IMO. Suggested rephrasing:
Done.
Is this a bugfix or a removal ? I don't think this was announced but...
Bugfix. This was not announced and added in a PR that had nothing to do with the behavior change, it was only supposed to improve the clarity of the error.
Also does this need to go in yet another 21.1 bugfix release, before people start relying on it ?
I'd really appreciate it if you could put it in a 21.1 bugfix release, or people might start relying on it. It would be particularly bad if a distro like Debian decides to pick 21.1 for their next stable release.
Per the discussion in pypa#9945. Signed-off-by: Filipe Laíns <lains@riseup.net>
|
Friendly ping. |
|
@pradyunsg if you're happy your review comments have been addressed, I think this can be merged. |
pradyunsg
approved these changes
Jun 7, 2021
|
@FFY00 Maybe you could rename the PR title? It's causing a little confusion - it's more "restore requiring pyproject.toml for setup.cfg-only projects". |
FFY00
changed the title
inmantaci
added a commit
to inmanta/inmanta-core
that referenced
this pull request
Jun 28, 2021
Bumps [pip](https://github.com/pypa/pip) from 21.1.2 to 21.1.3. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pypa/pip/blob/main/NEWS.rst">pip's changelog</a>.</em></p> <blockquote> <h1>21.1.3 (2021-06-26)</h1> <h2>Bug Fixes</h2> <ul> <li>Remove unused optional <code>tornado</code> import in vendored <code>tenacity</code> to prevent old versions of Tornado from breaking pip. (<code>[#10020](pypa/pip#10020) <https://github.com/pypa/pip/issues/10020></code>_)</li> <li>Require <code>setup.cfg</code>-only projects to be built via PEP 517, by requiring an explicit dependency on setuptools declared in pyproject.toml. (<code>[#10031](pypa/pip#10031) <https://github.com/pypa/pip/issues/10031></code>_)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pypa/pip/commit/e69a8f3987f44178dec8b9137158b4a6ed778ca3"><code>e69a8f3</code></a> Bump for release</li> <li><a href="https://github.com/pypa/pip/commit/c141edc5c90d0e3c2f40635516f151e2d02b5d95"><code>c141edc</code></a> remove support for setup.cfg only projects</li> <li><a href="https://github.com/pypa/pip/commit/363e90b62c3bfff14a4684545d54300007bb4d78"><code>363e90b</code></a> Avoid importing a non-vendored version of Tornado</li> <li><a href="https://github.com/pypa/pip/commit/4cab55f48ef2d05da40dd603910a68f81523ddd4"><code>4cab55f</code></a> Rephrase the warning printed when run as root on Unix</li> <li>See full diff in <a href="https://github.com/pypa/pip/compare/21.1.2...21.1.3">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
pradyunsg
changed the title
pradyunsg
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the discussion in #9945.
Signed-off-by: Filipe Laíns lains@riseup.net