Respect the base's constraint for extra-ed package #10239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
new-resolver-extra-dont-backtrack
branch
2 times, most recently
from
5e1fe3d
to
2d1d06f
Compare
1 task
pfmoore
approved these changes
Jul 30, 2021
| # "NAME[EXTRAS]" format, and parse out the name part with packaging or | ||
| # some regular expression. But since pip's resolver only spits out | ||
| # three kinds of identifiers: normalized PEP 503 names, normalized names | ||
| # plus extras, and Requires-Python, we can cheat a bit here. |
There was a problem hiding this comment.
I agree, this is a reasonable shortcut to take. Yes, if we ever spit out other types of identifier, this might need to change, but the comment can act as a reminder.
uranusjr
force-pushed
the
new-resolver-extra-dont-backtrack
branch
from
2d1d06f
to
95fa4e5
Compare
pfmoore
approved these changes
Jul 30, 2021
sbidoul
approved these changes
Jul 30, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10233