-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete type annotations of tests/functional/ directory #10464
Conversation
FWIW, for large PRs like this, I'd encourage you to make commits via |
Rebasing required several changes to newly added tests and exposed some too strict or loose types elsewhere. I've tried to contain these in the latest fixup commit. |
God dammit @jdufresne. Quicker at updating PRs than I am at mentioning that there's a merge conflict. (seriously though, I really really appreciate that you're keeping these PRs upto date) |
Rebased and resolved conflicts. |
@jdufresne one last time? |
Resolved conflict in |
No description provided.