Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for soon-EOL Python 3.6 #10641

Merged
merged 2 commits into from
Nov 12, 2021
Merged

Drop support for soon-EOL Python 3.6 #10641

merged 2 commits into from
Nov 12, 2021

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Nov 7, 2021

Python 3.6 to be dropped in pip 22.0: #10461 (comment).

We can also remove a bit of redundant Python 2 code.

@pradyunsg
Copy link
Member

Wheeeee! Thanks for picking this up @hugovk! ^.^

Could you also clear out the usage of utils.parallel and drop the module too? Those utilities are somewhat redundant/useless now that it's not possible/permitted to have a non-threading / non-multiprocessing platform.

@hugovk
Copy link
Contributor Author

hugovk commented Nov 8, 2021

How's this?

Copy link
Member

@DiddiLeija DiddiLeija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hugovk! It looks great now!

@@ -254,7 +253,7 @@ def latest_info(
dist.latest_filetype = typ
return dist

for dist in map_multithread(latest_info, packages):
for dist in map(latest_info, packages):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... We should bring this into a multi-threaded regime in a follow up!

@pradyunsg pradyunsg merged commit 71151fa into pypa:main Nov 12, 2021
@pradyunsg
Copy link
Member

OMIGOD. I JUST REALISED THAT WE CAN USE DATACLASSES NOW!

@hugovk hugovk deleted the rm-3.6 branch November 12, 2021 08:15
@hugovk
Copy link
Contributor Author

hugovk commented Nov 12, 2021

All the new* things!

https://docs.python.org/3/whatsnew/3.7.html

* 2018-06-27

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants