Make new resolver process Requires-Python before other dependencies #11398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoid an explicit requirement (name @ url) from being prepared too eagerly when its metadata is not required.
uranusjr
force-pushed
the
new-resolver-python-before-deps-fix
branch
from
ff4569a to
78ad423
Compare
This makes the resolver always inspect Requires-Python first when checking a candidate's consistency, ensuring that no other candidates are prepared if the Requires-Python check fails.
uranusjr
force-pushed
the
new-resolver-python-before-deps-fix
branch
from
78ad423 to
29ee616
Compare
|
Bump, what's the status on this PR? Is there some additional testing that needs to be done? If not, I can open a new one with the conflicts fixed if you'd like. |
|
I hate to be annoying, but I'd like to ask again what's blocking this PR from being ready for review. I see that there are some conflicts that need to be fixed and the patch can slightly cleaned up now that we target Python 3.8+ (re. |
This was referenced Jan 9, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11142. There are actually two issues; first is that the dist object in an ExplicitRequirement was being perpared too eagerly, the second is that Requires-Python should be returned before other dependencies so it is checked first.
This broke because resolvelib added a check to ensure a candidate’s dependencies are consistent. This new check made our lazy candidate preparation logic not lazy enough.