Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to exclude selected packages from vendoring upgrades #11503

Closed
wants to merge 3 commits into from

Conversation

pfmoore
Copy link
Member

@pfmoore pfmoore commented Oct 10, 2022

This allows us to deliberately exclude certain packages from our nox -s vendoring -- --upgrade script.

The UI is deliberately kept simple, you just add a list of packages to be excluded after --upgrade, like nox -s vendoring -- --upgrade certifi. Yes, this reads very badly (it looks like you're only going to upgrade certifi) but I wanted to avoid having to add an actual parser for posargs.

We always add setuptools to the exclusions - see 1466e7c which was included in #9170.

@pfmoore pfmoore requested a review from pradyunsg October 10, 2022 11:08
@pfmoore pfmoore added the skip news Does not need a NEWS file entry (eg: trivial changes) label Oct 10, 2022
@pradyunsg
Copy link
Member

x-ref #11500

@pradyunsg
Copy link
Member

pradyunsg commented Oct 25, 2022

I've blocked @hadesragnarokclassic, from the PyPA.

@github-actions github-actions bot added the needs rebase or merge PR has conflicts with current master label Feb 8, 2023
@pfmoore
Copy link
Member Author

pfmoore commented Apr 26, 2023

Abandoning this, as I now don't think it's really needed.

@pfmoore pfmoore closed this Apr 26, 2023
@pfmoore pfmoore deleted the vendor_selected branch April 26, 2023 11:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs rebase or merge PR has conflicts with current master skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants