Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vendored colorama #12702

Merged
merged 1 commit into from
May 14, 2024
Merged

Remove vendored colorama #12702

merged 1 commit into from
May 14, 2024

Conversation

ichard26
Copy link
Member

Pip's internal codebase doesn't use colorama anywhere. It was kept around for rich, but rich 12+ doesn't need it (opting to issue the appropriate Win32 API calls itself). pygments still imports colorama, but it's an optional dependency for the command line interface which pip evidently doesn't use.

~/dev/oss/pip ❯ git grep "colorama" **.py
src/pip/_internal/cli/spinners.py:    # even via colorama. So don't even try.
src/pip/_vendor/pygments/cmdline.py:        # unfortunately colorama doesn't support binary streams on Py3
src/pip/_vendor/pygments/cmdline.py:            import pip._vendor.colorama.initialise as colorama_initialise
src/pip/_vendor/pygments/cmdline.py:            outfile = colorama_initialise.wrap_stream(

Textualize/rich#1993

Pip's internal codebase doesn't use colorama anywhere. It was kept
around for rich, but rich 12+ doesn't need it (opting to issue the
appropriate Win32 API calls itself). pygments still imports colorama,
but it's an optional dependency for the command line interface which
pip evidently doesn't use.
@ichard26 ichard26 force-pushed the prune-vendoring-2 branch from e71c0ab to 817d4cf Compare May 14, 2024 21:26
@pradyunsg pradyunsg merged commit d2a48b2 into pypa:main May 14, 2024
28 checks passed
@ichard26 ichard26 deleted the prune-vendoring-2 branch May 15, 2024 19:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants