Rerun time based retry tests to avoid flaky failures #12869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested that this does in fact rerun flaky failures by inserting some |
pradyunsg
approved these changes
Jul 21, 2024
|
Merging as these are my own tests and the change is low risk (aiming to reduce the possibility of flaky failures, actually!) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address random failures like this one in #12865. Also increase the time tolerance to reduce the frequency of flaky failures.
Alternatively, we can simply delete these tests. They rely heavily on the system timer and sleep implementations being reliable and decently accurate, and it appears this is often not the case :(