Use dependency groups for test requirements #13475
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the test requirements out of requirements files into the
pyproject.tomlas dependency groups.Some choices I made:
1, I removed instructions about building a local setuptools wheel, as I don't think that's too relevant any more?
2. I just used the dependency group names directly in the nox script, I originally had a dependency group dictionary but it just mapped "test" to "test" and "test-common-wheels" to "test-common-wheels"
3. I have not created a "docs" dependency group as the requirements refers to a local directory, and groups can not include this so the instructions to install docs requirements would include both a group and a local file
Apart from being nice that this is using a feature that was worked on for pip in the way it was intended, the main advantage I think is it allows other tooling and users to more easily find these additional dependencies. I think it's more common to skim over a
pypyoject.tomlnow than it is to dig around looking forrequirements.txtfiles.