Skip to content

Conversation

@pelson
Copy link
Contributor

@pelson pelson commented Oct 15, 2025

Improve the typing of the with_cleanup decorator, as used by the download, install, lock, and wheel commands.

There is zero functional change in this PR, and the typing usage is functional back to Python 3.7 (at least), so should be no compatibility issues.

Originally identified as a result of #13599.

@sepehr-rs
Copy link
Member

Hi @pelson, thanks a lot for contributing to pip!
This PR looks mostly internal, so I think it doesn’t need a news item. Please note that it might take a bit of time for a maintainer to review, since the team works on a volunteer basis. Thanks for your patience!

@sepehr-rs sepehr-rs added the skip news Does not need a NEWS file entry (eg: trivial changes) label Oct 15, 2025
Copy link
Member

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ichard26 ichard26 enabled auto-merge (squash) October 18, 2025 17:11
@ichard26 ichard26 merged commit 4dd68aa into pypa:main Oct 18, 2025
28 checks passed
@pelson pelson deleted the typing/req_command branch October 19, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news Does not need a NEWS file entry (eg: trivial changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants