Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence byte compile errors when installation succeed. #1984

Merged
merged 7 commits into from
Aug 26, 2014
Merged

Silence byte compile errors when installation succeed. #1984

merged 7 commits into from
Aug 26, 2014

Conversation

berkerpeksag
Copy link
Member

Fixes #1873.

@berkerpeksag
Copy link
Member Author

Output with the patch:

$ pip install gunicorn
--download-cache has been deprecated and will be removed in  the future. Pip now automatically uses and configures its cache.
Downloading/unpacking gunicorn
  Downloading gunicorn-19.1.1-py2.py3-none-any.whl (104kB): 104kB downloaded
Installing collected packages: gunicorn
Compiling /home/berker/hacking/pip/venv/build/gunicorn/gunicorn/workers/_gaiohttp.py ...

Successfully installed gunicorn
Cleaning up...

@berkerpeksag berkerpeksag mentioned this pull request Aug 21, 2014
Closed
@berkerpeksag
Copy link
Member Author

I will squash the commits into one when the patch reviewed. I also will commit http://bugs.python.org/issue21338 to Python 3.5.

@wong2
Copy link

wong2 commented Aug 26, 2014

👏

dstufft added a commit that referenced this pull request Aug 26, 2014
@dstufft
Merge pull request #1984 from berkerpeksag/fix-1873
09a74c6 
Silence byte compile errors when installation succeed.
@dstufft dstufft merged commit 09a74c6 into pypa:develop Aug 26, 2014
@berkerpeksag berkerpeksag deleted the fix-1873 branch August 26, 2014 23:15
This was referenced Sep 29, 2014
Merged
Closed
@mbarrien mbarrien mentioned this pull request Oct 18, 2014
Closed
@jquast jquast mentioned this pull request Oct 14, 2015
Closed
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@berkerpeksag @wong2 @dstufft