Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displays info about [un]installed versions #2221

Merged
merged 1 commit into from
Dec 19, 2014

Conversation

msabramo
Copy link
Contributor

This is a variation on #2207 that doesn't write the output in package_name==version format, because @dstufft had some reservations about using that format and then people getting accustomed to it.

Displays version when installing and uninstalling -- e.g.:

Successfully installed pyrepl-0.8.4 pytest-2.6.4

and:

Uninstalling pyrepl-0.8.4:
  Successfully uninstalled pyrepl-0.8.4
Uninstalling pytest-2.6.4:
  Successfully uninstalled pytest-2.6.4

@msabramo msabramo force-pushed the display_installed_versions_2 branch 4 times, most recently from 781bc47 to 19b49cf Compare December 18, 2014 16:33
@msabramo
Copy link
Contributor Author

Cc: @dstufft, @pfmoore

@msabramo
Copy link
Contributor Author

Also see #2219 which does same for uninstall

@qwcode
Copy link
Contributor

qwcode commented Dec 18, 2014

in #2219, you're logging the representation of the pkg_resources Distribution object.

for consistency, couldn't you do just do that here?

i.e. query for the installed distribution using pkg_resources.get_distribution and log that.

@msabramo
Copy link
Contributor Author

@qwcode: Yeah, quite possibly. Thanks! Running tests locally now...

@msabramo
Copy link
Contributor Author

Tests failed.

Anyway, @qwcode made good points over at #2219 (comment) so I think I'll make both uninstall and install use similar (explicit) code and do it one PR.

@msabramo msabramo force-pushed the display_installed_versions_2 branch 2 times, most recently from 84bc6d9 to 5919f05 Compare December 19, 2014 01:10
Displays version when installing and uninstalling -- e.g.:

    Successfully installed pyrepl-0.8.4 pytest-2.6.4

and:

    Uninstalling pyrepl-0.8.4:
      Successfully uninstalled pyrepl-0.8.4
    Uninstalling pytest-2.6.4:
      Successfully uninstalled pytest-2.6.4
@msabramo msabramo changed the title Displays info about installed versions Displays info about [un]installed versions Dec 19, 2014
@msabramo
Copy link
Contributor Author

@dstufft, @pfmoore, @qwcode: This now adds the version to put for both install and uninstall. For both it separates the name and version with a hyphen. I purposely didn't use == because @dstufft had concerns that people might come to rely on it and be annoyed if we decided to remove it.

@pfmoore
Copy link
Member

pfmoore commented Dec 19, 2014

👍

dstufft added a commit that referenced this pull request Dec 19, 2014
Displays info about [un]installed versions
@dstufft dstufft merged commit bca8f91 into pypa:develop Dec 19, 2014
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants