-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use --depth=1 when checking out git repositories #2439
Conversation
Only "lightly tested" so far. A basic install from git (with and without tag) works, but I haven't tested the various combinations of update() and switch(). NB: (As written) this no longer supports checking out from an arbitrary commit - it needs to be branch name or tag. If this feature is considered critical, then fixing it probably involves recognising the situation and falling back to the previous (full checkout) behaviour :( |
pip installing from an arbitrary commit is very useful |
is that why Travis CI failed? |
In most uses of pip's git backend, we don't need the full git history - only the target head/branch/tag. This change adds --depth=1 to git fetch and clone commands. NB: "Shallow" checkouts are not supported from arbitrary git commits, so this change removes the ability to install from git SHA1 commit IDs. Tags and branches continue to be supported. Fixes pypa#2432
Yes, that should not be removed. @anguslees It could just use not See also NixOS's |
How does this fare against repos that use setuptools-scm |
Could setuptools-scm use |
its tricky to do and error prone, so #d like to avoid it, |
Accidentally closed this, reopening. Sorry! |
Hello! As part of an effort to ease the contribution process and adopt a more standard workflow pip has switched to doing development on the If you do nothing, this Pull Request will be automatically closed by @BrownTruck since it cannot be merged. If this pull request is still valid, please rebase it against If you choose to rebase/merge and resubmit this Pull Request, here is an example message that you can copy and paste:
|
This Pull Request was closed because it cannot be automatically reparented to the Please feel free to re-open it or re-submit it if it is still valid and you have rebased it onto |
In most uses of pip's git backend, we don't need the full git history -
only the target head/branch/tag. This change adds --depth=1 to git
fetch and clone commands.
Fixes #2432