Extract _copy_dist_from_dir from unpack_file_url #2533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now it's just a pretty simple `shutil.copytree`, but ideally we want it to do something more complex, involving building an sdist. Plus, this makes `unpack_file_url` fit on a single screen without scrolling for me. :-) See pypa#2195
|
Closing this in favor of #2535 |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it's just a pretty simple
shutil.copytree, but ideally we want it to do something more complex, involving building an sdist. And modularity is usually a good thing.Plus, this makes
unpack_file_urlfit on a single screen without scrolling for me. :-)See #2195