Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow creating wheels for editable packages #3379

Closed
wants to merge 1 commit into from
Closed

allow creating wheels for editable packages #3379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions pip/wheel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,11 +759,8 @@ def build(self, autobuilding=False):
if not autobuilding:
logger.info(
'Skipping %s, due to already being wheel.', req.name)
elif req.editable:
if not autobuilding:
logger.info(
'Skipping bdist_wheel for %s, due to being editable',
req.name)
elif autobuilding and req.editable:
pass
elif autobuilding and req.link and not req.link.is_artifact:
pass
elif autobuilding and not req.source_dir:
Expand Down
10 changes: 0 additions & 10 deletions tests/unit/test_wheel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,16 +380,6 @@ def test_skip_building_wheels(self, caplog):
assert "due to already being wheel" in caplog.text()
assert mock_build_one.mock_calls == []

def test_skip_building_editables(self, caplog):
with patch('pip.wheel.WheelBuilder._build_one') as mock_build_one:
editable = Mock(editable=True, is_wheel=False, constraint=False)
reqset = Mock(requirements=Mock(values=lambda: [editable]),
wheel_download_dir='/wheel/dir')
wb = wheel.WheelBuilder(reqset, Mock())
wb.build()
assert "due to being editable" in caplog.text()
assert mock_build_one.mock_calls == []


class TestWheelCache:

Expand Down