Deprecate the _strip_postfix function #4174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Erm, it appears this "feature" seems to be tested :p |
xavfernandez
force-pushed
the
deprecate_strip_postfix
branch
from
4917fcb
to
bfffa9f
Compare
|
I have no objection to it. It's not clear to me what the point would be for the functionality, and removing it seems simpler than trying to work out what obscure use case it satisfies, documenting it and supporting it going forward. If someone comes up with a justification for the feature during the deprecation period, we can reverse the decision. |
xavfernandez
force-pushed
the
deprecate_strip_postfix
branch
from
bfffa9f
to
1c76574
Compare
It only happens for editable-non-file URLs and is an undocumented behavior.
xavfernandez
force-pushed
the
deprecate_strip_postfix
branch
from
1c76574
to
a6b0d23
Compare
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It only happens for editable-non-file URLs and is an untested and
undocumented behavior.
cc @dstufft @pfmoore
This change is