Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendoring Updates - Late Oct 2017 #4819

Merged
merged 3 commits into from
Nov 3, 2017

Conversation

pradyunsg
Copy link
Member

Just a few standard updates.

Notably, the distlib update pulls a change that fixes #923.

@pradyunsg pradyunsg added the type: maintenance Related to Development and Maintenance Processes label Oct 28, 2017
@pradyunsg pradyunsg requested a review from a team October 28, 2017 13:18
@pradyunsg
Copy link
Member Author

@pfmoore Could you take a look?

Do you think these should wait until closer to a release?

@pfmoore
Copy link
Member

pfmoore commented Nov 3, 2017

Looks OK to me. IMO we shouldn't hold off on vendoring updates any more than on merging any other types of PR. It gives interested users a chance to test, after all...

@pradyunsg pradyunsg merged commit 87d2735 into pypa:master Nov 3, 2017
@pradyunsg pradyunsg deleted the vendoring/late-oct-2017 branch November 3, 2017 14:38
@pradyunsg
Copy link
Member Author

IMO we shouldn't hold off on vendoring updates any more than on merging any other types of PR.

Sounds good to me!

@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip does not support spaces in directories names
2 participants