Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 5085 (--user set in config causes pip wheel to fail) #5116

Merged
merged 3 commits into from
Mar 26, 2018

Conversation

pfmoore
Copy link
Member

@pfmoore pfmoore commented Mar 25, 2018

No description provided.

@pradyunsg
Copy link
Member

pradyunsg commented Mar 25, 2018

#4575 comes to mind but that's a little to big to wait on, maybe? I had a WIP PR for it, with a long checklist.

Otherwise, we can add a comment + document that --no-user is for internal use only, for now. Also, maybe try out and check if optparse is helpful and shows an error or something on --no-user --user or --user --no-user?

@pfmoore
Copy link
Member Author

pfmoore commented Mar 25, 2018

Yeah, I think #4575 is too much to rush into pip 10. Agreed I'm OK with this being a bit of a hack for now. Ideally we should switch to a better option parser (argparse or maybe click) in the longer term, so if this is a temporary workaround for limitations of optparse, I'm willing to live with it.

Ultimately, the fact that a user currently has no way of overriding a user=true setting in their config file is a problem - just not one that anyone has encountered in real life until now. I wonder if anyone has reported anything like this in relation to Debian's switch to --user by default, no time right now but I'll do a search maybe tomorrow.

@anntzer
Copy link
Contributor

anntzer commented Mar 25, 2018

fwiw --foo and --no-foo is a pretty standard scheme for boolean flags, with the standard convention that the last flag wins (but #4575 does looks nicer).

@pfmoore
Copy link
Member Author

pfmoore commented Mar 25, 2018

@anntzer Yes, that's what I'd expect - but optparse doesn't seem to implement that behaviour by default. I'll experiment a bit more tomorrow. Hopefully I missed something...

@pfmoore pfmoore changed the title WIP: Fix for issue 5085 (--user set in config causes pip wheel to fail) Fix for issue 5085 (--user set in config causes pip wheel to fail) Mar 26, 2018
@pfmoore pfmoore merged commit d6e050a into pypa:master Mar 26, 2018
@pfmoore pfmoore deleted the issue5085 branch March 26, 2018 13:27
@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants