Add mypy annotations for utils/appdirs #5925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I add a news entry or may we consider it trivial? |
cjerdonek
added
the
skip news
pradyunsg
reviewed
Oct 28, 2018
|
Could someone approve this please? |
pradyunsg
approved these changes
Nov 6, 2018
|
Thanks for the PR @mbaluna! Let us know you would like contribute more to pip and want any pointers. :) |
|
Thank you, @pradyunsg! I'm amazed at how responsive the community is. I'll need to ask around at my company (where I'm new at) about intellectual property stuff regarding future contributions. But anyway thanks 👍 |
|
Sure! Let me know if you can and wish to contribute. :) You're welcome to contribute to the project in the future! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4748