Added type hints to internals/utils #5932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
reviewed
Oct 27, 2018
src/pip/_internal/utils/glibc.py
Outdated
|
|
||
| def glibc_version_string(): | ||
| # type: () -> str |
There was a problem hiding this comment.
This should be type: () -> Optional[str]
There was a problem hiding this comment.
Ha, missed it - you are right. In process of rebasing, will include.
cjerdonek
added
the
skip news
Found a potential bug i.e. missing return statement in check_path_owner. If while loop falls through without returning, return a defensive False Added a trivial file as per the contributor guidelines Make linter happy - ignore "unused" import
petr-tik
force-pushed
the
no4748-add-type-hints-to-internals
branch
from
d9f9786
to
55f6787
Compare
pradyunsg
approved these changes
Oct 28, 2018
xavfernandez
approved these changes
Oct 29, 2018
|
Thanks @petr-tik! :) |
|
@petr-tik Let us know you would like contribute more to pip and want any pointers. :) |
|
Thanks again for the guidance |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a potential bug i.e. missing return statement in check_path_owner. If
while loop falls through without returning,
return a defensive False
related to #4748