Add mypy annotations to pip._internal.compat #5945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjerdonek
added
the
skip news
cytolentino
changed the title
cytolentino
force-pushed
the
compat-typing
branch
from
489e4f1
to
053ebb0
Compare
pradyunsg
reviewed
Oct 28, 2018
cytolentino
force-pushed
the
compat-typing
branch
from
053ebb0
to
a684493
Compare
pradyunsg
reviewed
Oct 30, 2018
src/pip/_internal/utils/compat.py
Outdated
| @@ -210,13 +224,15 @@ def samefile(file1, file2): | |||
|
|
|||
| if hasattr(shutil, 'get_terminal_size'): | |||
| def get_terminal_size(): | |||
| # type: () -> Tuple | |||
There was a problem hiding this comment.
This can be:
Suggested change
| # type: () -> Tuple | |
| # type: () -> Tuple[int, int] |
src/pip/_internal/utils/compat.py
Outdated
| else: | ||
| def get_terminal_size(): | ||
| # type: () -> Tuple |
There was a problem hiding this comment.
This can be:
Suggested change
| # type: () -> Tuple | |
| # type: () -> Tuple[int, int] |
|
Hey @cytolentino! Thanks for all the work toward this! :) Could you please address the two minor improvements with the annotations in the PR? |
cytolentino
force-pushed
the
compat-typing
branch
from
a684493
to
ecf90d4
Compare
|
No problem and sorry for the late response! Have just added in the [int, int] for those Tuples :) |
pradyunsg
approved these changes
Nov 6, 2018
|
Thanks @cytolentino! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add typing to pip._internal.compat as part of #4748