Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mypy annotations to pip._internal.cli.cmdoptions #5960

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

cytolentino
Copy link
Contributor

@cytolentino cytolentino commented Oct 28, 2018

Add mypy typing to pip._internal.cli.cmdoptions as part of #4748

@cytolentino cytolentino changed the title Add typing to cmdoptions.py Add mypy annotations to pip._internal.cli.cmdoptions Oct 28, 2018
@cjerdonek cjerdonek added the skip news Does not need a NEWS file entry (eg: trivial changes) label Oct 30, 2018
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor follow up I'd suggest is using TypedDict in place of the Dict[..., Any] annotations that we currently have.

@pradyunsg pradyunsg merged commit d95bc26 into pypa:master Oct 30, 2018
@lock
Copy link

lock bot commented May 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 31, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants