Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type annotations to most of the files in pip/_internal #6038

Closed
wants to merge 16 commits into from
Closed

Add type annotations to most of the files in pip/_internal #6038

wants to merge 16 commits into from

Conversation

mkurnikov
Copy link
Contributor

Fixes #4748.

Half of all # type: ignore in the codebase could be removed after mypy updated to latest version, will do it in the separate PR, or if this one will stay unmerged till 0.650 is out.

@mkurnikov mkurnikov changed the title Add types to most of the files in pip/_internal Add type annotations to most of the files in pip/_internal Nov 23, 2018
This was referenced Nov 23, 2018
Closed
Closed
@pradyunsg
Copy link
Member

Thanks for the PR!

It'd probably have been easier to review a bunch of smaller PRs. I'll try to make some time to review this sometime early next month.

@pradyunsg pradyunsg added the skip news Does not need a NEWS file entry (eg: trivial changes) label Nov 24, 2018
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Dec 1, 2018
@pradyunsg
Copy link
Member

Could you break up this PR into 4/5 smaller PRs?

@mkurnikov
Copy link
Contributor Author

wOk, np, will do it in a couple of days. type: ignore with something like "will be removed in the separate PRs" are fine?

@pradyunsg
Copy link
Member

pradyunsg commented Dec 2, 2018 •
edited
Loading

Thanks!

And, Yep.

This was referenced Dec 3, 2018
Merged
Merged
Merged
This was referenced Dec 3, 2018
Merged
Merged
Merged
Merged
@pradyunsg
Copy link
Member

Closing this PR.

@pradyunsg pradyunsg closed this Dec 8, 2018
@pradyunsg
Copy link
Member

Honestly, I'm not sure what's a good place to say this so, hey, thanks a ton for all the work here. It is genuinely much appreciated. :)

pradyunsg pushed a commit that referenced this pull request Dec 16, 2018
@mkurnikov @pradyunsg
Add type annotations for pip._internal.download, pip._internal.wheel …
7696e7e 
…and pip._internal.pep425tags (#6067)

References #4748, #6038.
pradyunsg pushed a commit that referenced this pull request Dec 17, 2018
@mkurnikov @pradyunsg
Add type annotations for pip._internal.operations (#6066)
7ee3881 
References #4748, #6038.
@lock
Copy link

lock bot commented May 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 31, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation needs rebase or merge PR has conflicts with current master skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding mypy annotations throughout the codebase
3 participants
@mkurnikov @pradyunsg @BrownTruck