Fix handling of requests exceptions when dependencies are debundled #6373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjerdonek
added
C: download
cjerdonek
approved these changes
Apr 3, 2019
|
Merging as this looks good on its face, as well as because of the following comment by @thomasgoirand that this resolves the Thank you, @yan12125, @cboylan, and @thomasgoirand for helping to track down and resolve this! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two issues with
DEBUNDLED = True:--extra-index-urlnot working well (NEED TESTING) (Changed behavior with --extra-index-url with pip 9 #4195)pip list -o --no-cache-diris broken if there are packages not hosted on PyPI. Tested on Arch Linux. (supersedes Fix handling of requests exceptions when dependencies are debundled #6111)Relevant PR: #6367
Notes for distro packagers: this patch works only if 8ef3283 is applied first.