Add mypy's no-strict-optional configuration inline #6750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm... Seems like that's non trivial. |
pradyunsg
force-pushed
the
misc/mypy-inline-no-strict-optional
branch
from
d17341f to
fac94f4
Compare
pradyunsg
force-pushed
the
misc/mypy-inline-no-strict-optional
branch
from
fac94f4 to
7c9d066
Compare
|
I would prefer if we did the mypy upgrade in a separate PR from changing the way the configuration is done. (I was working on that myself actually but got interrupted.) |
|
Yup yup. Happy to do so. There's a reason there's a commit "ffdljkghsjg" and this in a draft stage. :) |
pradyunsg
force-pushed
the
misc/mypy-inline-no-strict-optional
branch
2 times, most recently
from
27062a2 to
8294161
Compare
|
Alrighty. This is based on #6808 now. Once that's merged, we can merge this. :) |
pradyunsg
force-pushed
the
misc/mypy-inline-no-strict-optional
branch
from
8294161 to
f377148
Compare
|
Rebased on the current master. This is good to go IMO. I'll be merging this in ~24 hours unless someone flags concerns with this. :) |
pradyunsg
added
skip news
chrahunt
suggested changes
Aug 4, 2019
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't working but might be useful in case someone wants to follow up on this.
Related to #4748