-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move distributions/{source.py -> source/__init__.py} #6830
Move distributions/{source.py -> source/__init__.py} #6830
Conversation
I think we should avoid putting code in |
Agreed. Should I bundle it with the other changes I have planned in this sub-package?
I'm planning to follow up with changes to move logic invoked in preparing metadata to a separate module within this sub-package. That's the package this rename creates. |
I would just move it into a module in the package instead of into |
Ah okay. |
Maybe |
That's the eventual plan, yes. A legacy.py and anorher file (pep517.py? standard.py? I'm undecided and would appreciate help) would be added. That however, needs a few more cleanups to happen before I get to it. |
This would simplify for splitting up the build logic, in follow up commits.
9b3f782
to
e9d8e1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This would allow for splitting up the build logic when bringing it in.