Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move distributions/{source.py -> source/__init__.py} #6830

Merged

Conversation

pradyunsg
Copy link
Member

This would allow for splitting up the build logic when bringing it in.

@pradyunsg pradyunsg added type: refactor Refactoring code skip news Does not need a NEWS file entry (eg: trivial changes) labels Aug 4, 2019
@cjerdonek
Copy link
Member

I think we should avoid putting code in __init__.py if we can avoid it IMO. Is it needed for something?

@pradyunsg
Copy link
Member Author

pradyunsg commented Aug 4, 2019

I think we should avoid putting code in init.py if we can avoid it IMO.

Agreed. Should I bundle it with the other changes I have planned in this sub-package?

Is it needed for something?

I'm planning to follow up with changes to move logic invoked in preparing metadata to a separate module within this sub-package. That's the package this rename creates.

@cjerdonek
Copy link
Member

Should I bundle it with the other changes I have planned in this sub-package?

I would just move it into a module in the package instead of into __init__.py (e.g. distributions/source/whatever.py).

@pradyunsg
Copy link
Member Author

Ah okay.

@chrahunt
Copy link
Member

Maybe distributions/source/legacy.py?

@pradyunsg
Copy link
Member Author

That's the eventual plan, yes.

A legacy.py and anorher file (pep517.py? standard.py? I'm undecided and would appreciate help) would be added.

That however, needs a few more cleanups to happen before I get to it.

This would simplify for splitting up the build logic, in follow up
commits.
@pradyunsg pradyunsg force-pushed the move-source-distribution-to-sub-package branch from 9b3f782 to e9d8e1d Compare August 27, 2019 08:40
Copy link
Member

@chrahunt chrahunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pradyunsg pradyunsg merged commit 57fb9d5 into pypa:master Sep 5, 2019
@pradyunsg pradyunsg deleted the move-source-distribution-to-sub-package branch September 5, 2019 06:18
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: refactor Refactoring code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants