Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring req.constructors requirement parsing #7046

Merged
merged 2 commits into from
Sep 20, 2019
Merged

Refactoring req.constructors requirement parsing #7046

merged 2 commits into from
Sep 20, 2019

Conversation

chrahunt
Copy link
Member

Slowly extracting these into reusable functions.

@chrahunt chrahunt added skip news Does not need a NEWS file entry (eg: trivial changes) type: refactor Refactoring code labels Sep 20, 2019
@chrahunt
Copy link
Member Author

Thanks for the review @pradyunsg!

@chrahunt chrahunt merged commit 16f1b4b into pypa:master Sep 20, 2019
@chrahunt chrahunt deleted the refactor/constructors-req-parsing branch September 20, 2019 16:16
@chrahunt chrahunt mentioned this pull request Sep 22, 2019
Merged
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Oct 20, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: refactor Refactoring code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrahunt @pradyunsg