Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify handling of PEP 517 metadata temp dir #7100

Merged
merged 1 commit into from
Sep 28, 2019

Conversation

pradyunsg
Copy link
Member

I think the diff is fairly self-explanatory?

  • Not using temp_dir as a context manager here, so, the delete argument to __init__ has no effect and has been dropped.
  • Use a better, more descriptive name for temporary directory
  • Drop an unnecessary (and incorrect1) InstallRequirement.cleanup

1 self._temp_dir is not set anywhere except prepare_pep517_metadata, so it'll fail with an AttributeError for everything else.

@pradyunsg pradyunsg added type: refactor Refactoring code skip news Does not need a NEWS file entry (eg: trivial changes) labels Sep 28, 2019
@pradyunsg pradyunsg merged commit 1cbc28a into pypa:master Sep 28, 2019
@pradyunsg pradyunsg deleted the cleanup-pep-517-metadata-temp-dir branch September 28, 2019 10:05
@pradyunsg
Copy link
Member Author

Thanks for the review @pfmoore!

By any chance, would you have time to take a look at #7087? (it's perfectly cool if you don't)

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: refactor Refactoring code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants