Simplify handling of PEP 517 metadata temp dir #7100
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the diff is fairly self-explanatory?
temp_dir
as a context manager here, so, thedelete
argument to__init__
has no effect and has been dropped.InstallRequirement.cleanup
1
self._temp_dir
is not set anywhere exceptprepare_pep517_metadata
, so it'll fail with anAttributeError
for everything else.