Use pep517's new subprocess_runner API #7111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
added
skip news
|
Seems like I can use the new helper, to simplify our call to |
chrahunt
reviewed
Sep 29, 2019
Also, create a new utility function for showing a spinner when running a subprocess. Why: The subprocess_runner API was specifically added to make it possible for pip to stop monkey-patching Pep517HookCaller, while still maintaining its output style. The relevant monkeypatch will be removed in a follow up commit.
pradyunsg
force-pushed
the
refactor/use-pep517-subprocess_runner
branch
from
14c9fd5 to
1ad0495
Compare
|
It already is. :) |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #7104
Uses the dedicated API for this, added in pypa/pyproject-hooks#13.