Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize upgrade of already-satisfied pinned requirement #7132

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Optimize upgrade of already-satisfied pinned requirement #7132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/7132.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Skip reaching out to the package index, if a pinned version is already satisfied.
4 changes: 4 additions & 0 deletions src/pip/_internal/legacy_resolve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,10 @@ def _check_skip_installed(self, req_to_install):
# requirements we have to pull the tree down and inspect to assess
# the version #, so it's handled way down.
if not req_to_install.link:
if req_to_install.is_pinned:
pradyunsg marked this conversation as resolved.
Show resolved Hide resolved
# No need to check the index for a better version.
return 'already satisfied'

try:
self.finder.find_requirement(req_to_install, upgrade=True)
except BestVersionAlreadyInstalled:
Expand Down