Add partial CA info to pip debug #7208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pachwenko
force-pushed
the
add-pip-debug-cert-info
branch
from
96b8fda
to
5875a83
Compare
Pachwenko
force-pushed
the
add-pip-debug-cert-info
branch
from
5875a83
to
b7467b3
Compare
chrahunt
reviewed
Oct 15, 2019
| @@ -108,6 +111,15 @@ def run(self, options, args): | |||
| 'locale.getpreferredencoding', locale.getpreferredencoding(), | |||
| ) | |||
| show_value('sys.platform', sys.platform) | |||
| show_value( | |||
| 'os.environ.get(\'REQUESTS_CA_BUNDLE\')', | |||
There was a problem hiding this comment.
I would use REQUESTS_CA_BUNDLE for the name
| str(os.environ.get('REQUESTS_CA_BUNDLE')) | ||
| ) | ||
| show_value( | ||
| 'os.environ.get(\'CURL_CA_BUNDLE\')', |
There was a problem hiding this comment.
I would use CURL_CA_BUNDLE for the name
| @@ -0,0 +1 @@ | |||
| This change adds CA information to ``pip debug``. | |||
There was a problem hiding this comment.
May be clearer if worded like "Add CA certificate information to ``pip debug``."
|
Thanks for filing this @Pachwenko! There's another person working on this at PyCon India Sprints as well, so there would likely be another PR filed for this in a bit. |
|
Sweet! @pradyunsg @chrahunt I will close this PR and we can use #7216 which is fine with me. |
|
Thank you @Pachwenko! Would you like to work on a different issue in pip? |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7146 Still need to get the
highest-priority pip configuration filealong with its filepath. I am curious about the best way to do that and won't be sad if someone else wants to