-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add partial CA info to pip debug #7208
Conversation
96b8fda
to
5875a83
Compare
5875a83
to
b7467b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good, I just have a few minor comments.
@@ -108,6 +111,15 @@ def run(self, options, args): | |||
'locale.getpreferredencoding', locale.getpreferredencoding(), | |||
) | |||
show_value('sys.platform', sys.platform) | |||
show_value( | |||
'os.environ.get(\'REQUESTS_CA_BUNDLE\')', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use REQUESTS_CA_BUNDLE
for the name
str(os.environ.get('REQUESTS_CA_BUNDLE')) | ||
) | ||
show_value( | ||
'os.environ.get(\'CURL_CA_BUNDLE\')', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use CURL_CA_BUNDLE
for the name
@@ -0,0 +1 @@ | |||
This change adds CA information to ``pip debug``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be clearer if worded like "Add CA certificate information to ``pip debug``."
Thanks for filing this @Pachwenko! There's another person working on this at PyCon India Sprints as well, so there would likely be another PR filed for this in a bit. |
Sweet! @pradyunsg @chrahunt I will close this PR and we can use #7216 which is fine with me. |
Thank you @Pachwenko! Would you like to work on a different issue in pip? |
#7146 Still need to get the
highest-priority pip configuration file
along with its filepath. I am curious about the best way to do that and won't be sad if someone else wants to