Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug CA info #7210

Closed
wants to merge 2 commits into from
Closed

Debug CA info #7210

wants to merge 2 commits into from

Conversation

NeilBotelho
Copy link
Contributor

Added CA information to pip debug and added corresponding changes to test_debug.py
Fixes #7146

Added CA cert information to debug.py
Made the corresponding changes to tests/functional/test_debug.py
@NeilBotelho NeilBotelho deleted the debug-ca-info branch October 15, 2019 09:34
@NeilBotelho
Copy link
Contributor Author

The changes in debug.py didn't match the changes in test_debug.py
hence checks were failing. I'm closing this PR and will make a new one
with the appropriate corrections.

@pradyunsg
Copy link
Member

@NeilBotelho you don't need to close PRs. You can update a PR by pushing new commits to the same branch; the PR gets updated to include those commits.

@NeilBotelho
Copy link
Contributor Author

@NeilBotelho you don't need to close PRs. You can update a PR by pushing new commits to the same branch; the PR gets updated to include those commits.

Got it. Will keep that in mind going forward.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Nov 14, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SSL CA certificate information to pip debug
2 participants