-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put Temp on RAM Disk for Azure Pipelines tests #7263
Conversation
d653fa8
to
1979fe0
Compare
Nice, this saves about 10 minutes for integration tests, 30 seconds for unit tests, and only takes 1 minute extra for setup. It may be worth putting the tox environment in the same filesystem. Compare: |
Nice speedup ! |
Not sure what could be improved there, maybe FS-iSCSITarget-Server could be installed by default? I can clean up our config at least by moving it to a separate script and then invoke it from the yml file. |
Ideally a RAM disk would be available by default ? 😛 |
Well done! From looking at the logs, it looks like about 30 seconds of that setup is spent on cc @vtbassmatt -- something to consider pre-installing on the Windows image, depending on how much storage it eats up. |
e66cb6d
to
9be075a
Compare
Profiling on Azure Pipelines indicates that the majority of our time is spent waiting for filesystem operations to complete. As a quick way to improve our test speed in this area, we can do operations on a RAM disk instead of the default SSDs.
9be075a
to
ceaf75b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hurray!
Thanks for reviewing @pradyunsg and @xavfernandez, and @brcrista for initiating the agent image update request. I tested and |
@chrahunt if you haven't already, it might be worth investigating if this is a good idea on Appveyor as well, since that's our bottleneck CI service currently. |
We could also remove it entirely. Given 1 PR is submitted, currently we would have 4 idle runners on Azure Pipelines which could handle the 3 builds we do on Appveyor in parallel. |
I followed up on Azure Pipelines + GitHub Actions installing |
They've added this to their VM images now. |
👍 |
Profiling on Azure Pipelines indicates that the majority of our time is
spent waiting for filesystem operations to complete. As a quick way to
improve our test speed in this area, we can do operations on a RAM disk
instead of the default SSDs.
Related to #4497, #6791.