Add downloaded/local archive path to InstallRequirement #7483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help us avoid some complicated directory-changing logic in WheelBuilder.
Since it tests install_unpacked_wheel, the coverage should be the same.
Now we'll be able to transition other parts of the code to use pre-existing archives directly instead of relying on unpacked sources.
This removes one of usages of the overloaded `source_dir` member. We know the local_file_path must be set at this point because it is set in the only 3 places that wheels are added to InstallRequirement.
chrahunt
added
type: refactor
chrahunt
changed the title
|
Does this mean the |
|
Yes, it will. In a follow-up I was going to refactor it away and just unconditionally assign the built wheel path. |
pradyunsg
approved these changes
Dec 15, 2019
|
Thanks both of you for taking a look! |
This was referenced Jan 1, 2020
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the downloaded archive available on
InstallRequirement, which allows us to separate different phases of package processing. As an example, we now install directly from a wheel file (from the perspective ofInstallRequirement) instead of from an unpacked wheel insource_dir.Progresses #7049.