Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect quoting Link.url #7596

Merged
merged 5 commits into from
Feb 14, 2020
Merged

Fix incorrect quoting Link.url #7596

merged 5 commits into from
Feb 14, 2020

Conversation

uranusjr
Copy link
Member

@uranusjr uranusjr commented Jan 14, 2020 •
edited
Loading

Finishing #6958.

@uranusjr @atugushev
Fix incorrect quoting Link.url
cdd7821 
Cherry-picked manually from atugushev:fix-issue-6446.

Co-Authored-By: Albert Tugushev <albert@tugushev.ru>
@uranusjr uranusjr marked this pull request as ready for review January 15, 2020 08:27
@uranusjr
Copy link
Member Author

OK I think I’ve cherry-picked all the bits from the old PR to here, and all the comments in that PR have been addressed (mainly by @atugushev, I only fixed some linter issues).

@uranusjr uranusjr mentioned this pull request Jan 16, 2020
Open
@uranusjr
Copy link
Member Author

Soft ping. Anything I can do to push this forward?

pradyunsg
pradyunsg requested changes Feb 6, 2020
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, barring one documentation-related change.

news/6446.bugfix Outdated Show resolved Hide resolved
@uranusjr
Copy link
Member Author

uranusjr commented Feb 7, 2020

Don’t merge yet, I noticed a typo in the news fragment.

pradyunsg
pradyunsg reviewed Feb 7, 2020
View reviewed changes
news/6446.bugfix Outdated Show resolved Hide resolved
@uranusjr @pradyunsg
Fix typo in news fragment
c7184ec 
Co-Authored-By: Pradyun Gedam <pradyunsg@gmail.com>
@uranusjr
Copy link
Member Author

Now this is ready.

@pradyunsg pradyunsg merged commit cdae727 into pypa:master Feb 14, 2020
@uranusjr uranusjr deleted the 6446-link-url-quoting branch February 14, 2020 10:32
@uranusjr uranusjr mentioned this pull request Feb 14, 2020
Closed
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Mar 17, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbidoul sbidoul sbidoul left review comments

@pradyunsg pradyunsg pradyunsg approved these changes

@cjerdonek cjerdonek Awaiting requested review from cjerdonek

@chrahunt chrahunt Awaiting requested review from chrahunt

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uranusjr @sbidoul @pradyunsg