-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect quoting Link.url #7596
Conversation
Cherry-picked manually from atugushev:fix-issue-6446. Co-Authored-By: Albert Tugushev <albert@tugushev.ru>
1ae644d
to
cdd7821
Compare
OK I think I’ve cherry-picked all the bits from the old PR to here, and all the comments in that PR have been addressed (mainly by @atugushev, I only fixed some linter issues). |
Soft ping. Anything I can do to push this forward? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, barring one documentation-related change.
Don’t merge yet, I noticed a typo in the news fragment. |
Co-Authored-By: Pradyun Gedam <pradyunsg@gmail.com>
Now this is ready. |
Finishing #6958.