Skip to content

Revert "Explicitly set newline when rewriting for release" #7639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2020
Merged

Revert "Explicitly set newline when rewriting for release" #7639

merged 1 commit into from
Jan 23, 2020

Conversation

@pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented Jan 23, 2020

Reverts #7600

@pradyunsg pradyunsg added the skip news Does not need a NEWS file entry (eg: trivial changes) label Jan 23, 2020
@pradyunsg pradyunsg requested review from pfmoore and uranusjr January 23, 2020 07:46
@pradyunsg pradyunsg merged commit 54f9f83 into master Jan 23, 2020
@pradyunsg pradyunsg deleted the revert-7600-release-rewrite-lineendings branch January 23, 2020 10:23
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Feb 22, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pfmoore pfmoore pfmoore approved these changes

@uranusjr uranusjr Awaiting requested review from uranusjr

Assignees

No one assigned

Labels

auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pradyunsg @pfmoore