Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate installing packages w/o install-record.txt #7702

Closed
wants to merge 1 commit into from
Closed

Deprecate installing packages w/o install-record.txt #7702

wants to merge 1 commit into from

Conversation

pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented Feb 5, 2020 •
edited
Loading

Toward #7450

Does this sound reasonable?

@pradyunsg pradyunsg requested review from chrahunt and pfmoore February 5, 2020 19:38
@pfmoore
Copy link
Member

pfmoore commented Feb 5, 2020

+1 on the general principle of deprecating (and ultimately rejecting) misbehaving packages. Being able to rely on some basic assumptions will make it a lot easier to reason about the code.

chrahunt
chrahunt suggested changes Feb 6, 2020
View reviewed changes
Copy link
Member

@chrahunt chrahunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comment, otherwise this looks good to me.

src/pip/_internal/operations/install/legacy.py
@@ -73,7 +73,16 @@ def install(
)

if not os.path.exists(record_filename):
logger.debug('Record file %s not found', record_filename)
logger.warning('Record file %s not found', record_filename)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also mention the name of the package.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The record filename should include that. :P

You're right -- explicitly mentioning the pacakge name will more directly surface relevant info to the user. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm missing something it's just in a temporary directory with a generic name.

@pradyunsg pradyunsg added the type: deprecation Related to deprecation / removal. label Feb 6, 2020
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Feb 11, 2020
@pradyunsg
Copy link
Member Author

Good bot.

@pradyunsg pradyunsg closed this Apr 19, 2020
@pradyunsg pradyunsg deleted the deprecate-no-install-record-installs branch April 19, 2020 18:20
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrahunt chrahunt chrahunt requested changes

@pfmoore pfmoore pfmoore approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation needs rebase or merge PR has conflicts with current master type: deprecation Related to deprecation / removal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pradyunsg @pfmoore @BrownTruck @chrahunt