-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated sphinx to 2.4.0 #7720
Updated sphinx to 2.4.0 #7720
Conversation
Done @webknjaz! |
Closed and reopened, to retrigger CI. |
The CI failure does not seem to be related to the change in the PR. Maybe rebase it. |
Co-Authored-By: Pradyun Gedam <pradyunsg@gmail.com>
Oh no I think I messed the rebase up |
Never mind, its properly rebased now |
@pradyunsg it's ready |
Triggering CI again in the mean time. I want at least ReadTheDocs to pass since this is a change to the documentation toolchain. |
Everything is passing |
That took a bit of time! Thanks @RDIL for persisting and helping make sure that this gets done! |
No problem, just don't forget about #7767 since its also passing 😄 |
News fragment not needed
Fixes #7130