Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated sphinx to 2.4.0 #7720

Merged
merged 3 commits into from
Feb 28, 2020
Merged

Updated sphinx to 2.4.0 #7720

merged 3 commits into from
Feb 28, 2020

Conversation

RDIL
Copy link
Contributor

@RDIL RDIL commented Feb 11, 2020

News fragment not needed
Fixes #7130

@webknjaz
Copy link
Member

Hey @RDIL, please add "Fixes #7130" to the PR description.

@RDIL
Copy link
Contributor Author

RDIL commented Feb 11, 2020

Done @webknjaz!

@pradyunsg pradyunsg added the skip news Does not need a NEWS file entry (eg: trivial changes) label Feb 11, 2020
@RDIL RDIL requested a review from pradyunsg February 11, 2020 14:16
@pradyunsg pradyunsg closed this Feb 11, 2020
@pradyunsg pradyunsg reopened this Feb 11, 2020
@pradyunsg
Copy link
Member

Closed and reopened, to retrigger CI.

@webknjaz
Copy link
Member

The CI failure does not seem to be related to the change in the PR. Maybe rebase it.

RDIL and others added 3 commits February 27, 2020 19:20
@RDIL
Copy link
Contributor Author

RDIL commented Feb 27, 2020

Oh no I think I messed the rebase up

@RDIL
Copy link
Contributor Author

RDIL commented Feb 27, 2020

Never mind, its properly rebased now

@webknjaz
Copy link
Member

@pradyunsg it's ready

@uranusjr uranusjr closed this Feb 28, 2020
@uranusjr
Copy link
Member

Triggering CI again in the mean time. I want at least ReadTheDocs to pass since this is a change to the documentation toolchain.

@uranusjr uranusjr reopened this Feb 28, 2020
@RDIL
Copy link
Contributor Author

RDIL commented Feb 28, 2020

Everything is passing

@pradyunsg pradyunsg merged commit bf0da0f into pypa:master Feb 28, 2020
@pradyunsg
Copy link
Member

That took a bit of time! Thanks @RDIL for persisting and helping make sure that this gets done!

@RDIL RDIL deleted the patch-1 branch February 28, 2020 14:17
@RDIL
Copy link
Contributor Author

RDIL commented Feb 28, 2020

No problem, just don't forget about #7767 since its also passing 😄

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Apr 2, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linking to pip index page broken
4 participants