/tmp/pip-build fixes #780
/tmp/pip-build fixes #780
Conversation
… error message if the fd could not be opened (denied). Signed-off-by: David <db@d1b.org>
…s.exit()'ing and also document that on windows user temp directories are already isolated. Signed-off-by: David <db@d1b.org>
… directory is in fact owned by another user - add the os.O_NOFOLLOW flag to not follow symbolic links. Signed-off-by: David <db@d1b.org>
… use of the_get_build_prefix method to create a user specific build_prefix directory. Signed-off-by: David <db@d1b.org>
Signed-off-by: David <db@d1b.org>
| def _get_build_prefix(): | ||
| """ Returns a safe build_prefix """ | ||
| path = os.path.join(tempfile.gettempdir(), 'pip-build-%s' % \ | ||
| getpass.getuser()) |
There was a problem hiding this comment.
getpass.getuser() returns the value in the LOGNAME environment variable, so this doesn't work under sudo:
$ sudo LOGNAME=foo python
Python 2.6.6 (r266:84292, Oct 12 2012, 14:23:48)
[GCC 4.4.6 20120305 (Red Hat 4.4.6-4)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
import getpass
getpass.getuser()
'foo'
This should be based off of os.geteuid()
$ sudo LOGNAME=foo python
Python 2.6.6 (r266:84292, Oct 12 2012, 14:23:48)
[GCC 4.4.6 20120305 (Red Hat 4.4.6-4)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
import os
import pwd
pwd.getpwuid(os.geteuid()).pw_name
'root'
There was a problem hiding this comment.
I would expect LOGNAME to be 'root' under sudo.
I see that on ubuntu and centos.
There was a problem hiding this comment.
@timjr yes it should have been based off os.geteuid(), but getpass.getuser() is supported on windows and linux and so I used that.
lock
bot
added
the
auto-locked
fixes and doc/changelog updates on top of commits from pull #734