Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Version Mismatch Alert #7800

Closed
wants to merge 6 commits into from
Closed

Add Version Mismatch Alert #7800

wants to merge 6 commits into from

Conversation

anudit
Copy link
Contributor

@anudit anudit commented Feb 28, 2020

Prototype Implementation for #7797

@anudit
Copy link
Contributor Author

anudit commented Feb 28, 2020

@uranusjr @pradyunsg The checks are completed and passing on the Azure pipeline but don't seem to have propagated to GitHub.

@anudit
Copy link
Contributor Author

anudit commented Feb 28, 2020

@uranusjr @pradyunsg

Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel the message has some room for improvement; the current wording could be confusing to less experienced users. Python version mismatch… to what?

I have Python version 3.5 (for example), there’s nothing wrong with it?? (simulated response)

@anudit anudit requested a review from uranusjr February 29, 2020 02:32
"Link requires a different Python (3.6.5 not in: '== 3.6.4'): "
False, 'INFO',
"Package does not meet the Python version requirement. "
"Required version '== 3.6.4', Current version 3.6.5 "
"https://example.com"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The final link part looks weird to me, but I don’t have a good suggestion either 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link is utilized for testing as I see here

expected_return, expected_level, expected_message = expected
link = Link('https://example.com', requires_python='== 3.6.4')
caplog.set_level(logging.DEBUG)

@uranusjr
Copy link
Member

uranusjr commented Mar 1, 2020

The news fragment should be named 7797.feature to allow easy referencing the issue number in the changelog.

@anudit anudit requested a review from uranusjr March 1, 2020 08:31
@anudit
Copy link
Contributor Author

anudit commented Mar 2, 2020

The news fragment should be named 7797.feature to allow easy referencing the issue number in the changelog.

Updated, Should close #7797. @pfmoore @pradyunsg @chrahunt

@deveshks
Copy link
Contributor

Hi @anuditnagar

You should probably revisit the approach in this PR. As per #7797 (comment) , changing the message to logger.info would flood the output with a lot of Link requires a different Python.. messages, one for every package version being checked.

I just tried this on python2.7 when trying to install numpy as per the comment, and I got a total of 15 messages.

$ python --version
Python 2.7.16

$ pip install numpy
DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. pip 21.0 will drop support for Python 2.7 in January 2021. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support
  Link requires a different Python (2.7.16 not in: u'>=3.5'): https://files.pythonhosted.org/packages/c1/ff/aeb22192bab0643551a161dc4ed305892cead687ee97453daed4dc1dd38e/numpy-1.17.0rc1.zip#sha256=f53df05f9ca4ec5d72709ffe349704f1f7d945ed59e815574b5c5687acb282c4 (from https://pypi.org/simple/numpy/) (requires-python:>=3.5)
  Link requires a different Python (2.7.16 not in: u'>=3.5'): https://files.pythonhosted.org/packages/93/9b/443bbd1b38c4e5617f32c14c1494ae884d36cf3870c33828bb32e4b00dea/numpy-1.17.0rc2.zip#sha256=a4153fe85cf92a796022b81b138000160dea840cad13b7d1db67cfec594ece23 (from https://pypi.org/simple/numpy/) (requires-python:>=3.5)
  Link requires a different Python (2.7.16 not in: u'>=3.5'): https://files.pythonhosted.org/packages/da/32/1b8f2bb5fb50e4db68543eb85ce37b9fa6660cd05b58bddfafafa7ed62da/numpy-1.17.0.zip#sha256=951fefe2fb73f84c620bec4e001e80a80ddaa1b84dce244ded7f1e0cbe0ed34a (from https://pypi.org/simple/numpy/) (requires-python:>=3.5)
  Link requires a different Python (2.7.16 not in: u'>=3.5'): https://files.pythonhosted.org/packages/cb/79/96df883cd6df0c86cb010e6f4ff790b7a30a45016a9509c94ea72c8695cd/numpy-1.17.1.zip#sha256=f11331530f0eff69a758d62c2461cd98cdc2eae0147279d8fc86e0464eb7e8ca (from https://pypi.org/simple/numpy/) (requires-python:>=3.5)
  Link requires a different Python (2.7.16 not in: u'>=3.5'): https://files.pythonhosted.org/packages/ac/36/325b27ef698684c38b1fe2e546e2e7ef9cecd7037bcdb35c87efec4356af/numpy-1.17.2.zip#sha256=73615d3edc84dd7c4aeb212fa3748fb83217e00d201875a47327f55363cef2df (from https://pypi.org/simple/numpy/) (requires-python:>=3.5)
  Link requires a different Python (2.7.16 not in: u'>=3.5'): https://files.pythonhosted.org/packages/b6/d6/be8f975f5322336f62371c9abeb936d592c98c047ad63035f1b38ae08efe/numpy-1.17.3.zip#sha256=a0678793096205a4d784bd99f32803ba8100f639cf3b932dc63b21621390ea7e (from https://pypi.org/simple/numpy/) (requires-python:>=3.5)
  Link requires a different Python (2.7.16 not in: u'>=3.5'): https://files.pythonhosted.org/packages/ff/59/d3f6d46aa1fd220d020bdd61e76ca51f6548c6ad6d24ddb614f4037cf49d/numpy-1.17.4.zip#sha256=f58913e9227400f1395c7b800503ebfdb0772f1c33ff8cb4d6451c06cabdf316 (from https://pypi.org/simple/numpy/) (requires-python:>=3.5)
  Link requires a different Python (2.7.16 not in: u'>=3.5'): https://files.pythonhosted.org/packages/d9/09/8e89c05abc450ea347f40b4fa917ec5c69b5228da344487f178586a3187c/numpy-1.17.5.zip#sha256=16507ba6617f62ae3c6ab1725ae6f550331025d4d9a369b83f6d5a470446c342 (from https://pypi.org/simple/numpy/) (requires-python:>=3.5)
  Link requires a different Python (2.7.16 not in: u'>=3.5'): https://files.pythonhosted.org/packages/21/94/5d48401d922ad494399f74a973445d831c888ef0cd9437a4276d8a63cfe5/numpy-1.18.0rc1.zip#sha256=7b0b915190cf60e691c17147f5d955e273d4c482b795a7bb168ad4a2fe2fb180 (from https://pypi.org/simple/numpy/) (requires-python:>=3.5)
  Link requires a different Python (2.7.16 not in: u'>=3.5'): https://files.pythonhosted.org/packages/31/0a/5df350c29a06835d534a6c4f5681075304da38d85f1c69e5226a635a67ce/numpy-1.18.0.zip#sha256=a9d72d9abaf65628f0f31bbb573b7d9304e43b1e6bbae43149c17737a42764c4 (from https://pypi.org/simple/numpy/) (requires-python:>=3.5)
  Link requires a different Python (2.7.16 not in: u'>=3.5'): https://files.pythonhosted.org/packages/40/de/0ea5092b8bfd2e3aa6fdbb2e499a9f9adf810992884d414defc1573dca3f/numpy-1.18.1.zip#sha256=b6ff59cee96b454516e47e7721098e6ceebef435e3e21ac2d6c3b8b02628eb77 (from https://pypi.org/simple/numpy/) (requires-python:>=3.5)
  Link requires a different Python (2.7.16 not in: u'>=3.5'): https://files.pythonhosted.org/packages/84/1e/ff467ac56bfeaea51d4a2e72d315c1fe440b20192fea7e460f0f248acac8/numpy-1.18.2.zip#sha256=e7894793e6e8540dbeac77c87b489e331947813511108ae097f1715c018b8f3d (from https://pypi.org/simple/numpy/) (requires-python:>=3.5)
  Link requires a different Python (2.7.16 not in: u'>=3.5'): https://files.pythonhosted.org/packages/0c/e8/c49cb52ed2ad734efb49eb1f7766888b0e65df1848f71fa7f7fd52183392/numpy-1.18.3.zip#sha256=e46e2384209c91996d5ec16744234d1c906ab79a701ce1a26155c9ec890b8dc8 (from https://pypi.org/simple/numpy/) (requires-python:>=3.5)
  Link requires a different Python (2.7.16 not in: u'>=3.5'): https://files.pythonhosted.org/packages/2d/f3/795e50e3ea2dc7bc9d1a2eeea9997d5dce63b801e08dfc37c2efce341977/numpy-1.18.4.zip#sha256=bbcc85aaf4cd84ba057decaead058f43191cc0e30d6bc5d44fe336dc3d3f4509 (from https://pypi.org/simple/numpy/) (requires-python:>=3.5)
  Link requires a different Python (2.7.16 not in: u'>=3.5'): https://files.pythonhosted.org/packages/ab/19/b958d7edc81fe7cff0a7f8f981f9d87e9b13b0f3e03bcbb643cab68d5d4e/numpy-1.19.0rc1.zip#sha256=1ae657a2390cbc1553df60cb2a5f69742761d0ad5957b0113c9c00bb06276a78 (from https://pypi.org/simple/numpy/) (requires-python:>=3.5)
Collecting numpy
.....

@pradyunsg
Copy link
Member

Closing due to lack of movement here. Please feel free to file a new PR if you want to get the ball rolling again! :)

@pradyunsg pradyunsg closed this Feb 26, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants