Type annotations for completion and debug in commands #8051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deveshks
force-pushed
the
add-mypy-annotations-comp-dbg
branch
2 times, most recently
from
2b7e1ca
to
ae8391b
Compare
McSinyx
reviewed
Apr 19, 2020
|
May I get this PR looked at for implementation reviews? |
pradyunsg
reviewed
May 15, 2020
pradyunsg
reviewed
May 15, 2020
The requested changes are made, and the CI is passing. Please let me know if any other changes are needed. |
pradyunsg
approved these changes
May 15, 2020
|
Thanks for the approval and merge @pradyunsg I have two more PRs which deal with adding type annotations to other files in commands (#8016 and #8018) with almost similar changes to this. Would appreciate whenever you could take a look at them as well 😊 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #4748
Added type annotations to
pip._internal.commands.completionandpip._internal.commands.debug