WIP: add --prefer-minimum-versions flag #8086
Conversation
Add a flag to the resolver to make it try to use older versions instead of newer versions for all dependencies. This is useful for running test suites using the "lower bounds" of requirements to ensure that they are accurate. Signed-off-by: Doug Hellmann <doug@doughellmann.com>
dhellmann
force-pushed
the
prefer-minimum-versions
branch
from
eb6bbc8 to
e7a44f3
Compare
There was a problem hiding this comment.
As noted by the failing CI checks, please don't modify code in _vendor. That is not "pip code" but instead libraries that are shipped as part of pip. You can find more detail here: https://pip.pypa.io/en/latest/development/vendoring-policy/
dhellmann
force-pushed
the
prefer-minimum-versions
branch
from
6e74053 to
1c9a19d
Compare
Only the provider find_matches() method really needs to be changed. Signed-off-by: Doug Hellmann <doug@doughellmann.com>
dhellmann
force-pushed
the
prefer-minimum-versions
branch
from
1c9a19d to
6885efa
Compare
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Yeah, I'm aware. This is still experimental. When we agree on the real implementation, I'll propose the patches correctly, but until then it gives us something concrete to discuss. |
|
Hello! I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the |
Add a flag to the resolver to make it try to use older versions
instead of newer versions for all dependencies. This is useful for
running test suites using the "lower bounds" of requirements to ensure
that they are accurate.
Addresses #8085
This PR currently has no tests and modifies a vendored library in place. I wanted to post it for review as a way to show what I'm asking for in #8085. If there is general agreement that the feature would be a good addition, I will take care of updating resolverlib separately and then reworking this PR accordingly, including adding tests. I'm also looking for feedback on the command line flag name.