Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop parallelization in pip list #8167

Merged
merged 2 commits into from
May 7, 2020
Merged

Drop parallelization in pip list #8167

merged 2 commits into from
May 7, 2020

Conversation

pradyunsg
Copy link
Member

Closes #8161
Supercedes and closes #8162

Reverts the main change in #7962

TBH, at this point, I feel like we should revert the original PR until we figure out the finer details of what we want parallelized code in pip to look like, what strategy we use to support platforms that don't have threading etc.

Originally posted by @pradyunsg in #8162 (comment)

@pradyunsg pradyunsg added C: list/show 'pip list' or 'pip show' type: maintenance Related to Development and Maintenance Processes type: bugfix labels Apr 29, 2020
@pradyunsg pradyunsg marked this pull request as draft April 29, 2020 09:40
@McSinyx
Copy link
Contributor

McSinyx commented Apr 29, 2020

Where should we discuss multithreading in the (near) future, a new ticket or in GH-8162?

@pfmoore
Copy link
Member

pfmoore commented Apr 29, 2020

@McSinyx In my view, it should be a new issue, probably entitled something like "Should pip support platforms that don't include threading?" And in the summary, explain that we have various proposals for using multithreading to speed up pip (mention the pip list --outdated PR and the proposal to do multi-threaded downloads, and anything else you're aware of) and we need to decide whether we simply require threading for pip, or we have to provide fallbacks. And if we provide fallbacks, how do we test, how do we structure the code, etc, etc.

That should make for a lively debate 🙂

@landfillbaby
Copy link

landfillbaby commented Apr 29, 2020 •
edited
Loading

I've closed #8162 since this is arguably better
See also: #8169

@landfillbaby landfillbaby mentioned this pull request Apr 29, 2020
Closed
@pradyunsg pradyunsg added this to the 20.1.1 milestone May 5, 2020
@pradyunsg pradyunsg marked this pull request as ready for review May 5, 2020 10:44
@pradyunsg
Copy link
Member Author

pradyunsg commented May 7, 2020 •
edited
Loading

CI is happy with this change. I am happy with this change.

Could I get a review so that I don't feel guilty about merging this without approving reviews? :)

pfmoore
pfmoore approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ask, and ye shall receive 🙂

@pradyunsg pradyunsg merged commit 5cac4dc into pypa:master May 7, 2020
@pradyunsg pradyunsg deleted the drop-list-parallelization branch May 7, 2020 18:27
@landfillbaby landfillbaby mentioned this pull request May 11, 2020
Closed
pradyunsg added a commit to pradyunsg/pip that referenced this pull request May 19, 2020
@pradyunsg
Merge pull request pypa#8167 from pradyunsg/drop-list-parallelization
4a063b7
bors bot referenced this pull request in duckinator/emanate May 19, 2020
@bors @pyup-bot
Merge #126
48b6adb 
126: Update pip to 20.1.1 r=duckinator a=pyup-bot


This PR updates [pip](https://pypi.org/project/pip) from **20.1** to **20.1.1**.



<details>
  <summary>Changelog</summary>
  
  
   ### 20.1.1
   ```
   ===================

Deprecations and Removals
-------------------------

- Revert building of local directories in place, restoring the pre-20.1
  behaviour of copying to a temporary directory. (`7555 &lt;https://github.com/pypa/pip/issues/7555&gt;`_)
- Drop parallelization from ``pip list --outdated``. (`8167 &lt;https://github.com/pypa/pip/issues/8167&gt;`_)

Bug Fixes
---------

- Fix metadata permission issues when umask has the executable bit set. (`8164 &lt;https://github.com/pypa/pip/issues/8164&gt;`_)
- Avoid unnecessary message about the wheel package not being installed
  when a wheel would not have been built. Additionally, clarify the message. (`8178 &lt;https://github.com/pypa/pip/issues/8178&gt;`_)
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/pip
  - Changelog: https://pyup.io/changelogs/pip/
  - Homepage: https://pip.pypa.io/
</details>



Co-authored-by: pyup-bot <github-bot@pyup.io>
@McSinyx McSinyx mentioned this pull request Jun 27, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pfmoore pfmoore pfmoore approved these changes

Assignees
No one assigned
Labels
C: list/show 'pip list' or 'pip show' type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Milestone
20.1.1
Development

Successfully merging this pull request may close these issues.

pip list --outdated fails on platforms without sem_open
4 participants
@pradyunsg @McSinyx @pfmoore @landfillbaby