Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pip/_internal/*): Use custom raise_for_status method #8189

Merged
merged 2 commits into from
Jul 15, 2020
Merged

feat(pip/_internal/*): Use custom raise_for_status method #8189

merged 2 commits into from
Jul 15, 2020

Conversation

gutsytechster
Copy link
Contributor

This inherits the behaviour of requests.Response.raise_for_status and define our own custom raise_for_status method, with main difference in the final exception raised.

Towards #5380

@gutsytechster gutsytechster force-pushed the remove_raise_for_status branch from 68e624f to 2620fc8 Compare May 4, 2020 16:50
@uranusjr
Copy link
Member

uranusjr commented May 4, 2020

This looks good to me! Only a few minor comments.

uranusjr
uranusjr reviewed May 4, 2020
View reviewed changes
news/5380.feature Outdated Show resolved Hide resolved
@pradyunsg pradyunsg added C: network connectivity type: enhancement Improvements to functionality labels May 5, 2020
@gutsytechster gutsytechster force-pushed the remove_raise_for_status branch from 2620fc8 to 6052cce Compare May 5, 2020 12:02
@gutsytechster
Copy link
Contributor Author

If the changes are satisfactory, then can we merge this?

@uranusjr
Copy link
Member

@gutsytechster I think we want to wait until the 20.1 release cycle settles (i.e. hopefully after 20.1.1 is out).

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label May 20, 2020
@gutsytechster gutsytechster force-pushed the remove_raise_for_status branch from 6052cce to f05f07d Compare May 21, 2020 09:38
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label May 21, 2020
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label May 23, 2020
@gutsytechster gutsytechster force-pushed the remove_raise_for_status branch from f05f07d to 9bd0391 Compare May 24, 2020 10:21
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label May 24, 2020
@gutsytechster gutsytechster force-pushed the remove_raise_for_status branch 2 times, most recently from 0ef0c72 to 4b38cc5 Compare May 24, 2020 10:45
@uranusjr uranusjr added this to the 20.2 milestone May 24, 2020
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Jul 1, 2020
@pradyunsg
Copy link
Member

@gutsytechster Thanks for the multiple updates on this PR!

Would you be willing to update it once more, so that we can go ahead and merge this? Or would you prefer that someone else takes this forward from here? I'd like to get this into pip 20.2 (due this month), but this is certainly not a blocker in any form.

@gutsytechster
Copy link
Contributor Author

@pradyunsg sure I'd love to work upon it. However, I currently don't have my system with me. It's been a month now as it's gone for repair. I feel that I should get it in the next few days. If there is no hurry, then I'd want to complete the work. Otherwise, no issue from my side if someone else takes up the PR in case of urgency.

@gutsytechster gutsytechster force-pushed the remove_raise_for_status branch from 4b38cc5 to 07e8712 Compare July 9, 2020 09:46
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Jul 9, 2020
@gutsytechster
Copy link
Contributor Author

The failed tests doesn't seem related to the changes. It seems there is some connection issue with some tests. Not really sure though.

@gutsytechster gutsytechster reopened this Jul 10, 2020
@pradyunsg pradyunsg merged commit fa2fcee into pypa:master Jul 15, 2020
@pradyunsg
Copy link
Member

Thanks @gutsytechster! ^>^

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@uranusjr uranusjr uranusjr approved these changes

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
C: network connectivity type: enhancement Improvements to functionality
Projects
None yet
Milestone
20.2
Development

Successfully merging this pull request may close these issues.
5 participants
@gutsytechster @uranusjr @BrownTruck @pradyunsg @pypa-bot