Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL links need to be reinstalled as versions cant be checked properly #8198

Closed
wants to merge 1 commit into from
Closed

URL links need to be reinstalled as versions cant be checked properly #8198

wants to merge 1 commit into from

Conversation

NickHilton
Copy link

@NickHilton NickHilton commented May 6, 2020

  • If a requirement is being installed from a URL we can't check the version properly so force reinstall

NOTES

  • This affects packages installed via a requirements.txt file or setup.py - install_requires file
  • Installing a package via pip install git+URL from the command line is not be affected as version is parsed correctly

BENEFITS

  • Avoids the silent bug where a user expects a package to be installed with a specified version or branch

CONSIDERATIONS

  • Will make installation slower if the URL version has NOT changed as it will reinstall anyway

ISSUE

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Aug 3, 2020
@sbidoul sbidoul added the C: direct url Direct URL references (PEP 440, PEP 508, PEP 610) label Aug 4, 2020
@sbidoul
Copy link
Member

sbidoul commented Aug 4, 2020

The new resolver improves things in this area. I encourage you to give it a try. See #5780 (comment) and following comment for the current status and improvement suggestions.

@pradyunsg
Copy link
Member

Closing since this is significantly out of date.

@pradyunsg pradyunsg closed this Apr 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: direct url Direct URL references (PEP 440, PEP 508, PEP 610) needs rebase or merge PR has conflicts with current master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants