-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helpers to TestPipResult #8303
Conversation
There is already #8295 posted for this. |
@deveshks I will go on and close those PRs and as @pradyunsg mentioned here we will go on and work on using the helpers on pip's tests. :) |
Whhops! I definitely missed that PR (sorry!). None the less, I think @ssurbhi560 resolved the overlapping PRs conflict (thanks!) so, there's not really much for me to say or do here now. |
@ssurbhi560 @gutsytechster Your turn. ;) |
Thanks, @pradyunsg for the merge. :) |
@gutsytechster I haven't yet started updating any files, so it'd be better if you let me know which ones you have already updated (and going to do) and then I will start working on remaining ones! |
@ssurbhi560 as I can find, we have these 11 files to be updated:
I've taken reference from your previous PR https://github.com/pypa/pip/pull/7869/files. We can distribute the files, let's say you may go with the first 5 and I can go with the rest of them. Does it make sense? PS: Please mention any other file in case I might've not noticed or mentioned. |
@gutsytechster sounds perfect to me!
So, I would go on and work with the first five from the list you mentioned above and the first two from the list of remaining files. Does this sounds good? |
Sounds like a plan to me :) 👍 |
I'm a little late but I find that those helpers' names lack an |
It was... I figured that it wasn't necessary. If you reckon it'd be helpful, I'm happy to file a PR myself after all the transitory PRs are merged. :) |
I reckon it'd be helpful but if I'm the only one, I'll adapt. |
I haven't been following the discussion, but I'd also be mildly in favour of having |
Same feeling as @xavfernandez here. To me |
(sorry, I did not mean to insist, the last comment was not refreshed in my browser tab) |
Alrighty. Let's do the |
Supercedes #7869, unblocking the rest of the work, toward updating all the call sites in our tests.