Mark new resolver test failure on extra union #8482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
added
skip news
pradyunsg
approved these changes
Jun 23, 2020
Member
pradyunsg
left a comment
pradyunsg
left a comment
There was a problem hiding this comment.
Huh, we have all sorts of weirdness in our test suite. :)
pfmoore
approved these changes
Jun 24, 2020
Member
|
Agreed it looks like this test can just be removed. But let's worry about that another day. I'm losing the will to live trying to work out why some of our tests even exist. I'm going to merge this for now, at least. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
fails_on_new_resolverfromtest_install_distribution_union_with_versions. I have zero idea why this can be considered valid in the first place—maybe we should just remove this test altogether instead?The test will need to be fixed when we improve the error message, should maybe we should do that first and rebase/fix this PR later.